Feat: Delete upgrade information only rather than calling abort in TimeoutExecuted #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangdv2429
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5764 +/- ##
==========================================
- Coverage 81.59% 81.54% -0.05%
==========================================
Files 199 199
Lines 15167 12079 -3088
==========================================
- Hits 12375 9850 -2525
+ Misses 2326 1764 -562
+ Partials 466 465 -1
|
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
crodriguezvega
approved these changes
Feb 6, 2024
damiannolan
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Thanks for pushing that last commit @crodriguezvega ❤️
LGTM!
charleenfei
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5742
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.